This repository was archived by the owner on Mar 26, 2025. It is now read-only.
fix: relax min otel version #309
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkaye97
reviewed
Feb 3, 2025
There was a problem hiding this comment.
@grutt I think this might not work - did you test out installing an older otel version and using our SDK? In this version of the OTel packages (the one that's currently our min), they added support for protobuf 5+ and dropped support for 3 and 4, and so I don't think our code will run on an older version that this since we use protobuf 5 iirc
I can check on this to make sure, but just wanted to flag it
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.