Log Search Frontend, Part II #2886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements bug fixes and styling improvements for the log search frontend interface. The changes focus on improving user experience by fixing interaction issues with text selection and autocomplete, as well as enhancing the visual design.
Changes:
- Fixed text selection in log lines to prevent accidental collapse when selecting/copying text
- Improved autocomplete behavior by removing default pre-selection and closing the search bar on Enter
- Enhanced visual design with color indicators for log levels and always-visible filter chips
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
frontend/app/src/components/v1/cloud/logging/log-search/types.ts |
Added LOG_LEVEL_COLORS constant and optional color property to AutocompleteSuggestion interface |
frontend/app/src/components/v1/cloud/logging/log-search/log-search-input.tsx |
Updated selectedIndex to be optional, modified keyboard navigation, restructured popover to always show filter chips, and improved Enter key behavior to close popover |
frontend/app/src/components/v1/cloud/logging/log-search/autocomplete.ts |
Added color property to level suggestions using LOG_LEVEL_COLORS |
frontend/app/src/components/v1/cloud/logging/components/Terminal.tsx |
Added window selection check to prevent log line toggle when user is selecting text |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abelanger5
approved these changes
Jan 29, 2026
* fix: propagate retry count through properly * feat: attempt switcher * fix: attempt numbers * feat: add attempt param to log query * feat: wiring * feat: attempt filter * chore: changelog * fix: use the button component * fix: only close on enter when in FTS mode * fix: pass retry count and log level in Go * fix: feedback * chore: lint * fix: rm cruft comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing a couple bugs / making some styling tweaks:
levelType of change