fix: dag update distinct locks #2903
Open
+32
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
abelanger5
approved these changes
Feb 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes prevent potential issues where the same task or DAG could appear multiple times in the update queries, which could cause lock contention or duplicate update attempts. Identified in #2829
Type of change
What's Changed
DISTINCT ONwhen selecting tasks to lock inUpdateTaskOLAPStatusto prevent duplicate rows from being lockeddistinct_tasks_to_lock) to first deduplicate tasks before acquiringFOR UPDATElocksDISTINCT ONfix todags_to_updatequery to prevent duplicate DAG status updatesORDER BYclauses to ensure deterministic row selection when deduplicating