Feat--unify-running-and-evicted#3248
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
📝 Documentation updates detected! New suggestion: Clarify evicted task status representation in task eviction docs Tip: Sort by Shortest Review in the Dashboard to find quick wins ⚡ |
mrkaye97
left a comment
mrkaye97
left a comment
There was a problem hiding this comment.
couple small comments, but mostly looks good
| return result | ||
| } | ||
|
|
||
| func mapOlapStatus(olapStatus string) (gen.V1TaskStatus, bool) { |
There was a problem hiding this comment.
should this be a string or an enum?
| let newValue; | ||
| if (checked) { | ||
| newValue = [...selectedValues, option.value]; | ||
| if (subColumn && option.subOptions) { | ||
| subColumn.setFilterValue(undefined); | ||
| } | ||
| } else { | ||
| newValue = selectedValues.filter( | ||
| (v) => v !== option.value, | ||
| ); | ||
| if (subColumn) { | ||
| subColumn.setFilterValue(undefined); | ||
| } | ||
| } | ||
| column?.setFilterValue( | ||
| newValue.length > 0 ? newValue : undefined, | ||
| ); |
There was a problem hiding this comment.
this stuff (and the same below for onCheckedChange) feels really complicated. can we simplify this somehow? I'm having trouble figuring out what it's doing
There was a problem hiding this comment.
yeah i put very little effort here because i REALLY want to rip this and replace it with our nice filters we use in the logs component ASAP... more pain here maybe we'll do it
There was a problem hiding this comment.
yeah, good call, would love that too 😅
Benchmark resultsCompared against |
3 participants
Description
Unifies single count for running + evicted and exposes new params for granular details and filtering
Type of change