Gracefully handle empty bulk scheduled deletes#3279
Merged
mrkaye97 merged 3 commits intohatchet-dev:mainfrom Mar 15, 2026
Merged
Gracefully handle empty bulk scheduled deletes#3279mrkaye97 merged 3 commits intohatchet-dev:mainfrom
mrkaye97 merged 3 commits intohatchet-dev:mainfrom
Conversation
|
@avirajkhare00 is attempting to deploy a commit to the Hatchet Team on Vercel. A member of the Team first needs to authorize it. |
mrkaye97
reviewed
Mar 14, 2026
Contributor
mrkaye97
left a comment
mrkaye97
left a comment
There was a problem hiding this comment.
thanks for this change! I left one small comment on existing patterns, but broadly looks great 👍
Comment on lines
9
to
23
| config *server.ServerConfig | ||
| workflowSchedules v1.WorkflowScheduleRepository | ||
| } | ||
|
|
||
| func NewWorkflowService(config *server.ServerConfig) *WorkflowService { | ||
| var workflowSchedules v1.WorkflowScheduleRepository | ||
| if config != nil && config.V1 != nil { | ||
| workflowSchedules = config.V1.WorkflowSchedules() | ||
| } | ||
|
|
||
| return &WorkflowService{ | ||
| config: config, | ||
| config: config, | ||
| workflowSchedules: workflowSchedules, | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
let's not do this - I agree that this is a clean approach, but we don't have this pattern anywhere else so I'd prefer to be consistent
mrkaye97
reviewed
Mar 14, 2026
mrkaye97
approved these changes
Mar 14, 2026
Contributor
mrkaye97
left a comment
mrkaye97
left a comment
There was a problem hiding this comment.
great stuff! will let CI pass and then merge - thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3269
Testing