net: replace CFG_TUD_NET_ENDPOINT_SIZE with actual descriptor-based ep size#3568
Open
net: replace CFG_TUD_NET_ENDPOINT_SIZE with actual descriptor-based ep size#3568
Conversation
… bInterval to TUD_CDC_NCM_DESCRIPTOR Co-authored-by: HiFiPhile <4375114+HiFiPhile@users.noreply.github.com> Agent-Logs-Url: https://github.com/hathach/tinyusb/sessions/e212b526-e279-4a83-88bf-a742df293165
Collaborator
|
@copilot remove submodules |
Contributor
Author
Collaborator
|
@copilot Remove CFG_TUD_NET_ENDPOINT_SIZE, manage zlp based on real speed in drivers |
… in drivers Co-authored-by: HiFiPhile <4375114+HiFiPhile@users.noreply.github.com> Agent-Logs-Url: https://github.com/hathach/tinyusb/sessions/5d355974-2223-4071-8d14-b6d4ac1fd030
…ired_zlp Co-authored-by: HiFiPhile <4375114+HiFiPhile@users.noreply.github.com> Agent-Logs-Url: https://github.com/hathach/tinyusb/sessions/5d355974-2223-4071-8d14-b6d4ac1fd030
Contributor
Author
Done in c843e5e. Removed |
Copilot
AI
changed the title
Upgrading net_lwip_webserver example with separate descriptors for FS and HS
Upgrade net_lwip_webserver example with separate FS/HS descriptors and improve NCM/ECM ZLP handling
Mar 22, 2026
…coding 64/512 Co-authored-by: HiFiPhile <4375114+HiFiPhile@users.noreply.github.com> Agent-Logs-Url: https://github.com/hathach/tinyusb/sessions/4c20b579-db28-4643-b062-81881adcf6c1
Copilot
AI
changed the title
Upgrade net_lwip_webserver example with separate FS/HS descriptors and improve NCM/ECM ZLP handling
net: replace CFG_TUD_NET_ENDPOINT_SIZE with actual descriptor-based ep size
Mar 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes network class ZLP handling by basing decisions on the negotiated bulk endpoint wMaxPacketSize read from descriptors at netd_open() time, instead of compile-time or hardcoded speed assumptions (important for dual-speed devices).
Changes:
- Remove
CFG_TUD_NET_ENDPOINT_SIZEand store actual bulk EP max packet size in the network interface state for ECM/RNDIS and NCM. - Update ZLP decision logic to use the stored descriptor-derived endpoint size.
- Update the net_lwip_webserver example to provide distinct FS/HS configuration descriptors and add HS support descriptors (device qualifier / other-speed config callbacks).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/device/usbd.h |
Extends the CDC-NCM descriptor template macro to include an interrupt bInterval parameter. |
src/class/net/net_device.h |
Removes the compile-time endpoint size macro previously used for ZLP decisions. |
src/class/net/ncm_device.c |
Stores bulk EP max packet size from descriptors and uses it for ZLP insertion logic. |
src/class/net/ecm_rndis_device.c |
Stores bulk EP max packet size from descriptors and uses it for ZLP decisions. |
examples/device/net_lwip_webserver/src/usb_descriptors.c |
Splits FS/HS configurations (64 vs 512), adds device qualifier + other-speed configuration callbacks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Size Difference ReportBecause TinyUSB code size varies by port and configuration, the metrics below represent the averaged totals across all example builds. Note: If there is no change, only one value is shown. Changes >1% in sizeNo entries. Changes <1% in size
No changes
|
…OTHER_SPEED_CONFIG and fix SEED typo Co-authored-by: HiFiPhile <4375114+HiFiPhile@users.noreply.github.com> Agent-Logs-Url: https://github.com/hathach/tinyusb/sessions/3d21b8d3-b2df-4603-a426-2bcfdb408f04
Co-authored-by: HiFiPhile <4375114+HiFiPhile@users.noreply.github.com> Agent-Logs-Url: https://github.com/hathach/tinyusb/sessions/3d21b8d3-b2df-4603-a426-2bcfdb408f04
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. |
HiFiPhile
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFG_TUD_NET_ENDPOINT_SIZEused a compile-timeTUD_OPT_HIGH_SPEEDflag to pick between 512 and 64, which is incorrect when a device supports both speeds. ZLP decisions must be based on the actual negotiated endpoint size.Changes
CFG_TUD_NET_ENDPOINT_SIZEfromnet_device.hecm_rndis_device.c/ncm_device.c: Adduint16_t ep_sizeto the interface struct; populate it duringnetd_open()by readingwMaxPacketSizedirectly from the bulk endpoint descriptor viatu_edpt_packet_size()(IN and OUT assumed equal, matching the pattern inmtp_device.c)ep_sizeinstead of runtimetud_speed_get()with hardcoded values🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.