Conversation
Signed-off-by: HiFiPhile <admin@hifiphile.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refreshes the i.MX RT Teensy 4.0/4.1 BSP’s MCUXpresso Config Tools artifacts (pins/clocks) and updates the DEBUG UART pin routing to LPUART6.
Changes:
- Bump MCUXpresso Config Tools metadata/config schema versions for Teensy 4.0 and 4.1.
- Regenerate pin mux and clock config outputs, including DEBUG UART pin routing to LPUART6.
- Minor cleanup/metadata adjustments in generated files (e.g., additional clock consumer comments, GPIO init value define).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hw/bsp/imxrt/boards/teensy_41/teensy41.mex | Updates MEX schema/tool versions and routes DEBUG UART pins to LPUART6. |
| hw/bsp/imxrt/boards/teensy_41/board/pin_mux.h | Updates generated pin symbols (incl. LED init value); removes old UART1 routed-pin macros. |
| hw/bsp/imxrt/boards/teensy_41/board/pin_mux.c | Updates generated pin muxing/config for DEBUG UART to LPUART6. |
| hw/bsp/imxrt/boards/teensy_41/board/clock_config.h | Regenerated clock defines with additional consumer annotations. |
| hw/bsp/imxrt/boards/teensy_41/board/clock_config.c | Updates Clocks tool metadata versioning header. |
| hw/bsp/imxrt/boards/teensy_40/teensy40.mex | Updates MEX schema/tool versions and routes DEBUG UART pins to LPUART6. |
| hw/bsp/imxrt/boards/teensy_40/board/pin_mux.h | Updates generated pin symbols (incl. LED init value); removes old UART1 routed-pin macros. |
| hw/bsp/imxrt/boards/teensy_40/board/pin_mux.c | Updates generated pin muxing/config for DEBUG UART to LPUART6. |
| hw/bsp/imxrt/boards/teensy_40/board/clock_config.h | Regenerated clock defines with additional consumer annotations. |
| hw/bsp/imxrt/boards/teensy_40/board/clock_config.c | Updates Clocks tool metadata versioning header. |
Comments suppressed due to low confidence (2)
hw/bsp/imxrt/boards/teensy_40/teensy40.mex:92
- The Pins tool config switches DEBUG_UART pins to LPUART6, but the Peripherals section still defines an instance named "DEBUG_UART" with peripheral="LPUART1" (around line ~523). Update that instance (or remove/rename it) so the .mex configuration matches the PR’s stated default-debug-UART change and avoids generating inconsistent code from MCUXpresso tools.
<dependency resourceType="Peripheral" resourceId="LPUART6" description="Peripheral LPUART6 signals are routed in the Pins Tool, but the peripheral is not initialized in the Peripherals Tool." problem_level="1" source="Pins:BOARD_InitDEBUG_UARTPins">
<feature name="initialized" evaluation="equal">
<data>true</data>
</feature>
</dependency>
hw/bsp/imxrt/boards/teensy_41/teensy41.mex:92
- The Pins tool config switches DEBUG_UART pins to LPUART6, but the Peripherals section still defines an instance named "DEBUG_UART" with peripheral="LPUART1" (around line ~523). Update that instance (or remove/rename it) so the .mex configuration matches the PR’s stated default-debug-UART change and avoids generating inconsistent code from MCUXpresso tools.
<dependency resourceType="Peripheral" resourceId="LPUART6" description="Peripheral LPUART6 signals are routed in the Pins Tool, but the peripheral is not initialized in the Peripherals Tool." problem_level="1" source="Pins:BOARD_InitDEBUG_UARTPins">
<feature name="initialized" evaluation="equal">
<data>true</data>
</feature>
</dependency>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Size Difference ReportBecause TinyUSB code size varies by port and configuration, the metrics below represent the averaged totals across all example builds. Note: If there is no change, only one value is shown. Changes >1% in sizeNo entries. Changes <1% in sizeNo entries. No changes
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Teensy 4.0 board support package to use newer MCUXpresso configuration tools and changes the default debug UART from
LPUART1toLPUART6. It also updates the pin and clock configuration files to match these changes and cleans up related code and metadata.