Open
Conversation
Author
|
No fancy changes, just upgraded to the latest SDK for flutter, made changes to the Android SDK in build.gradle, migrated xcode projects for ios and macos to latest xcode versions. There were minor changes in example dart files like removing vsync parameter, removing unsupported calls for fullscreen, and some permissions related APIs. Kindly let me know, if you'd like anything else before this can be merged. |
Author
|
Let me know if any other changes are needed before this can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
The examples had some overdue maintenance, and didn't compile correctly on the latest Flutter SDK.
There were also some small changes in the drawing_animation APIs that were not up-to-date in the examples.
I updated the examples, so that it compiles and works correctly on latest Flutter and drawing_animation package.
Please accept the PR.
ps: Thank you authoring and maintaining this package.