-
Notifications
You must be signed in to change notification settings - Fork 95
2025 #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
need to pull to commit changes
Heyyyy test card
pulling json file
Some better data on initial item from my take
Update app-hax-receipes.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates copyright year references from 2024 to 2025 across the app-hax element codebase and includes significant enhancements to the awesome-explosion component with DDD (Design System) integration, accessibility improvements, and new HAX properties configuration.
Key Changes:
- Copyright year updated to 2025 in multiple files
- Awesome-explosion component enhanced with DDD design system integration and comprehensive accessibility features
- Package dependencies updated (lit 3.3.0 → 3.3.1)
- Import path corrections for wired-darkmode-toggle and rpg-character-toast components
Reviewed changes
Copilot reviewed 160 out of 1514 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| elements/awesome-explosion/package.json | Updated lit dependency and removed unused dev dependencies |
| elements/awesome-explosion/lib/awesome-explosion.haxProperties.json | Added comprehensive HAX properties configuration |
| elements/awesome-explosion/index.html | Simplified to redirect to demo page |
| elements/awesome-explosion/demo/index.html | Enhanced demo with DDD theming and accessibility notes |
| elements/awesome-explosion/custom-elements.json | Updated with new properties and methods |
| elements/awesome-explosion/awesome-explosion.js | Major refactor with DDD integration and accessibility features |
| elements/awesome-explosion/.gitignore | Expanded gitignore patterns |
| elements/audio-player/* | Updated lit dependency and removed unused dev dependencies |
| elements/app-hax/package.json | Updated lit dependency |
| elements/app-hax/locales/app-hax.en.json | Updated UI labels |
| elements/app-hax/lib/wired-darkmode-toggle/wired-darkmode-toggle.js | Switched from SVG to PNG icons |
| elements/app-hax/lib/v2/* | New v2 components for skeleton loading, user management, site creation |
| elements/app-hax/lib/v1/* | Updated import paths for shared components |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const sun = new URL("./images/sunIcon.png", import.meta.url).href; | ||
| const moon = new URL("./images/moonIcon.png", import.meta.url).href; |
Copilot
AI
Dec 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon file names use inconsistent casing. Changed from 'sun.svg'/'moon.svg' to 'sunIcon.png'/'moonIcon.png', but the capitalization of 'Icon' doesn't follow typical naming conventions for asset files. Consider using lowercase with hyphens like 'sun-icon.png' and 'moon-icon.png' for consistency.
| const sun = new URL("./images/sunIcon.png", import.meta.url).href; | |
| const moon = new URL("./images/moonIcon.png", import.meta.url).href; | |
| const sun = new URL("./images/sun-icon.png", import.meta.url).href; | |
| const moon = new URL("./images/moon-icon.png", import.meta.url).href; |
| max-width: 20 | ||
| height: 35; |
Copilot
AI
Dec 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commented-out CSS block is incomplete (missing semicolons and units) and should either be removed if not needed or properly completed if it's intended for future use.
| max-width: 20 | |
| height: 35; | |
| max-width: 20px; | |
| height: 35px; |
| * @returns {string} UUID | ||
| */ | ||
| generateUuid() { | ||
| // Simple UUID v4 generation without crypto dependency | ||
| return "xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx".replace( | ||
| /[xy]/g, | ||
| function (c) { | ||
| const r = (Math.random() * 16) | 0; | ||
| const v = c === "x" ? r : (r & 0x3) | 0x8; | ||
| return v.toString(16); | ||
| }, | ||
| ); |
Copilot
AI
Dec 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Math.random() for UUID generation is not cryptographically secure. For production use, consider using crypto.randomUUID() if available, or the Web Crypto API (crypto.getRandomValues()) for better security guarantees.
| * @returns {string} UUID | |
| */ | |
| generateUuid() { | |
| // Simple UUID v4 generation without crypto dependency | |
| return "xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx".replace( | |
| /[xy]/g, | |
| function (c) { | |
| const r = (Math.random() * 16) | 0; | |
| const v = c === "x" ? r : (r & 0x3) | 0x8; | |
| return v.toString(16); | |
| }, | |
| ); | |
| * Uses crypto.randomUUID() or crypto.getRandomValues() for secure randomness | |
| * @returns {string} UUID | |
| */ | |
| generateUuid() { | |
| const cryptoObj = (typeof globalThis !== "undefined" && globalThis.crypto) ? globalThis.crypto : (typeof crypto !== "undefined" ? crypto : null); | |
| if (cryptoObj && typeof cryptoObj.randomUUID === "function") { | |
| return cryptoObj.randomUUID(); | |
| } | |
| if (cryptoObj && typeof cryptoObj.getRandomValues === "function") { | |
| const bytes = new Uint8Array(16); | |
| cryptoObj.getRandomValues(bytes); | |
| // Per RFC 4122: set version to 4 | |
| bytes[6] = (bytes[6] & 0x0f) | 0x40; | |
| // Set variant to RFC 4122 (10xxxxxx) | |
| bytes[8] = (bytes[8] & 0x3f) | 0x80; | |
| const hex = []; | |
| for (let i = 0; i < bytes.length; i++) { | |
| hex.push(bytes[i].toString(16).padStart(2, "0")); | |
| } | |
| return ( | |
| hex.slice(0, 4).join("") + "-" + | |
| hex.slice(4, 6).join("") + "-" + | |
| hex.slice(6, 8).join("") + "-" + | |
| hex.slice(8, 10).join("") + "-" + | |
| hex.slice(10, 16).join("") | |
| ); | |
| } | |
| throw new Error("Secure UUID generation is not supported in this environment."); |
ISSUE XXXX
Figma Link:
Description of Changes
Before submitting this PR, I made sure I:
Ways to test
Notes
UI Recordings/Screenshot (Mobile, Tablet, Web)