Fix package manager detection to respect packageManager field in monorepos#213
Closed
Fix package manager detection to respect packageManager field in monorepos#213
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…repos Co-authored-by: haydenbleasel <4142719+haydenbleasel@users.noreply.github.com>
Co-authored-by: haydenbleasel <4142719+haydenbleasel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Init issues in monorepo
Fix package manager detection to respect packageManager field in monorepos
Jul 13, 2025
Owner
|
@copilot please rebase |
Contributor
Author
I understand you'd like me to rebase this branch, but due to security limitations, I cannot perform git rebase operations that require force pushing. The branch is currently based on v5.0.34 while main is at v5.0.44. Would you prefer me to:
I can apply the same package manager detection fixes to the current main branch if that would work better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
ultracite initwould use the wrong package manager in monorepos when there was a conflict between the explicitpackageManagerfield inpackage.jsonand existing lockfiles.Problem
When running
ultracite initin a monorepo with:packageManagerfield specifying bun (e.g.,"packageManager": "bun@1.0.0")pnpm-lock.yamlfile from previous usageworkspacesfield indicating monorepo structureUltracite would incorrectly use
pnpm add -winstead of respecting the explicitbun addconfiguration, leading to errors like:Solution
Modified the package manager detection logic in
scripts/package-manager.tsto:packageManagerfield first - Parse the field frompackage.json(e.g.,"bun@1.0.0"→"bun")Changes
packageManager.get()to prioritize explicit configuration over lockfile detectionTesting
Before:
After:
packageManagerfield is absentFixes #188.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.