Skip to content

Conversation

@ihsandemir
Copy link
Collaborator

@ihsandemir ihsandemir commented Dec 22, 2025

Codecov publish fix. Avoiding to do this caused the publish action find and use extra coverage files for the test files which were excluded when running the gcov.

If you look at the current run and download the coverage_report.zip you can see that the test directory is actually excluded but it is published differently to codecov.

The details on the config option disable_search is here more details here.

fixes #1308

Here is the proof that this works. The test folder is not included.

Avoiding to do this caused the publich action find and use extra coverage files for the test files which were excluded when running the gcov.

fixes #1308
@ihsandemir ihsandemir added this to the 5.6.0 milestone Dec 22, 2025
@ihsandemir ihsandemir self-assigned this Dec 22, 2025
@ihsandemir ihsandemir changed the title Codecov publish fix Codecov publish fix [HZ-5302] Dec 22, 2025
@JackPGreen
Copy link
Contributor

and even when I add the workflow_dispatch: it did not work, I can not see manual trigger button.

try adding pull_request instead and it’ll trigger on your PR. I’d like to see this fix “working” because I don’t have context on the cause of the problem - where did this fix come from? Did someone else suggest it?

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.61%. Comparing base (529eac0) to head (d71899b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1381      +/-   ##
==========================================
+ Coverage   81.10%   88.61%   +7.51%     
==========================================
  Files         216      161      -55     
  Lines       34777    19559   -15218     
  Branches     2044        0    -2044     
==========================================
- Hits        28207    17333   -10874     
+ Misses       6364     2226    -4138     
+ Partials      206        0     -206     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ihsandemir
Copy link
Collaborator Author

and even when I add the workflow_dispatch: it did not work, I can not see manual trigger button.

try adding pull_request instead and it’ll trigger on your PR. I’d like to see this fix “working” because I don’t have context on the cause of the problem - where did this fix come from? Did someone else suggest it?

Just changed it and there is a run result already.

@ihsandemir ihsandemir enabled auto-merge (squash) December 22, 2025 10:40
@ihsandemir ihsandemir merged commit 31daf75 into master Dec 22, 2025
46 checks passed
@ihsandemir ihsandemir deleted the codecove_publish_fix branch December 22, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

codecov reporting does not exclude the test folder correctly [API-2346]

3 participants