Fixed warnings in windows compilation [HZ-5297] #1385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackPGreen
requested changes
Dec 26, 2025
Contributor
JackPGreen
left a comment
JackPGreen
left a comment
There was a problem hiding this comment.
The changes mostly seem to be tightening types (explicit casting etc).
I don't know which warning(s) are being fixed, but I have no real issue with the changes as presented beyond what I've highlighted.
hazelcast/include/hazelcast/client/impl/metrics/metrics_compressor.h
Outdated
Show resolved
Hide resolved
emreyigit
previously approved these changes
Dec 29, 2025
JackPGreen
requested changes
Dec 29, 2025
Contributor
JackPGreen
left a comment
JackPGreen
left a comment
There was a problem hiding this comment.
Re-reviewed (GitHub forced me to add a comment as well)
ihsandemir
added a commit
to ihsandemir/hazelcast-cpp-client
that referenced
this pull request
Dec 30, 2025
…AGS [HZ-5297] (hazelcast#1386) Replaced `sizeof(frame_header_type)` with `SIZE_OF_FRAME_LENGTH_AND_FLAGS`. fixes hazelcast#1385 (comment)
ihsandemir
changed the title
…conversions and dll imports.
Co-authored-by: Jack Green <[email protected]>
``` hazelcast-cpp-client\hazelcast\src\hazelcast\client\compact.cpp(3349,58): warning C4146: unary minus operator applied to unsigned type, result still unsigned ``` The original code `-(fp & 1L)` does convert the -1 tu uint64_t implicitly but this causes a compiler warning, instead we explicitly cast it and multiply to get the same result. Regarding the value of -(fp & 1L), this is 0 if least siginificant bit of fp is 0 otherwise it results in negated value of 1 which is all 1 bits uint64_t.
ihsandemir
force-pushed
the
warningFixes
branch
from
87cc22a to
c2ccfbc
Compare
JackPGreen
requested changes
Jan 5, 2026
| #include "hazelcast/util/export.h" | ||
| #include "hazelcast/client/serialization/pimpl/compact/field_descriptor.h" | ||
|
|
||
| #if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64) |
Contributor
There was a problem hiding this comment.
Shouldn’t be here. Disabled globally already?
(Also occurs elsewhere)
Collaborator
Author
There was a problem hiding this comment.
yes, you are right. i do not know how it became like this given the rebasing. I fixed them now in 2 files.
JackPGreen
approved these changes
Jan 5, 2026
| } // namespace serialization | ||
| } // namespace client | ||
| } // namespace hazelcast | ||
| } // namespace hazelcast |
Contributor
There was a problem hiding this comment.
Nit - change of line ending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed warning in windows compilation. Most warnings were due to type conversions and dll imports.
fixes #1350