Disable ttl based tests in ClientMapTest suite for near cache client [HZ-5308] [HZ-5310] #1388
Conversation
| ASSERT_FALSE((imap_ | ||
| ->put_if_absent<std::string, std::string>( | ||
| "key1", "value3", std::chrono::seconds(10)) | ||
| .get() | ||
| .has_value())); |
There was a problem hiding this comment.
Why did this get reformatted?
There was a problem hiding this comment.
line changed and used clang-format to format. do you mean the indentation of the lines?
There was a problem hiding this comment.
do you mean the indentation of the lines?
Yes.
The codebase should have a consistent format now so this shouldn't have needed to change. If it did, then there must be a tooling difference between our respective clang-formats?
There was a problem hiding this comment.
Oh it changed. From ASSERT_FALSE -> ASSERT_FALSE_EVENTUALLY. Ignore me.
There was a problem hiding this comment.
Well, the build Build&Test PR / enforce-code-formatting (pull_request_target) is green :)
There was a problem hiding this comment.
I dislike the magic 10 but as you've highlighted, it already exists in hazelcast.
…a test https://github.com/hazelcast/hazelcast-mono/blob/aad45696a4bb784c6a538e22d26f183973ace9c4/hazelcast/hazelcast/src/test/java/com/hazelcast/client/map/ClientMapTest.java#L542. The problem was that we dependent on timing on the entry expiry and 1 second may not be enough in busy times. Hence, it is changed to 10 seconds. We also re-put the entry with 10 seconds ttl in the send put also to avoid expiry when we checked the value in the next step. fixes hazelcast#1145
ihsandemir
changed the title
ihsandemir
changed the title
ihsandemir
force-pushed
the
testPutWithTtlTestFix
branch
from
2134cde to
4c198d4
Compare
2 participants
Disabled ttl based tests for near cache based test cases due to an issue at server side hazelcast/hazelcast#10975
Fixed ClientMapTest.testPutIfAbsentTtl so that it is in sync with Java test https://github.com/hazelcast/hazelcast-mono/blob/aad45696a4bb784c6a538e22d26f183973ace9c4/hazelcast/hazelcast/src/test/java/com/hazelcast/client/map/ClientMapTest.java#L542. The problem was that we dependent on timing on the entry expiry and 1 second may not be enough in busy times. Hence, it is changed to 10 seconds. We also re-put the entry with 10 seconds ttl in the send put also to avoid expiry when we checked the value in the next step.
opened #1390 so that we do not forget to re-open these tests.
fixes #1145
fixes #1181