Add README instructions to examples [HZ-5257] #1395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihsandemir
changed the title
JackPGreen
requested changes
Jan 14, 2026
examples/cp/README.md
Outdated
Comment on lines
3
to
7
| - Start server: | ||
|
|
||
| ```bash | ||
| java -jar hazelcast-enterprise-<SERVER VERSION>.jar | ||
| ``` |
Contributor
There was a problem hiding this comment.
Rather than duplicating this, could we just link to a single reference, or the public docs?
| - Start server: | ||
|
|
||
| ```bash | ||
| java -jar hazelcast-enterprise-<SERVER VERSION>.jar |
Contributor
There was a problem hiding this comment.
Does this need to be EE?
Comment on lines
3
to
4
| - Write the java class corresponding to the Car class and put that class or jar (`<my_factory>.jar`) into the classpath | ||
| when starting the server and also add a server config for adding the serializer factory to the server. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Write the java class corresponding to the Car class and put that class or jar (`<my_factory>.jar`) into the classpath | |
| when starting the server and also add a server config for adding the serializer factory to the server. | |
| - Write the Java class corresponding to the Car class and put that class or jar (`<my_factory>.jar`) into the classpath | |
| when starting the server and also add a server config for adding the serializer factory to the server. |
nit
Comment on lines
3
to
4
| - Write the java class corresponding to the `employee` class and put that class or jar (`<my_factory>.jar`) into the | ||
| classpath when starting the server and also add a server config for adding the serializer factory to the server. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Write the java class corresponding to the `employee` class and put that class or jar (`<my_factory>.jar`) into the | |
| classpath when starting the server and also add a server config for adding the serializer factory to the server. | |
| - Write the Java class corresponding to the `employee` class and put that class or jar (`<my_factory>.jar`) into the | |
| classpath when starting the server and also add a server config for adding the serializer factory to the server. |
nit
dmitriyrazboev
previously approved these changes
Jan 15, 2026
Eliminated unneeded repeated README files. Put more information at the top level README of examples folder and only put example specific README if any example specific instruction is needed.
dmitriyrazboev
approved these changes
Jan 16, 2026
JackPGreen
reviewed
Jan 16, 2026
| In order to run the portable example (`sql_query_with_portable`), you need to | ||
| Write the Java class corresponding to the `Person` class, it's serializer class and put that class or | ||
| jar (`<my_factory>.jar`) into the classpath when starting the server and also add a server config for adding the | ||
| serializer factory to the server. |
Contributor
There was a problem hiding this comment.
Suggested change
| serializer factory to the server. | |
| serializer factory to the server. | |
Nit line ending
JackPGreen
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add README instructions to examples.