Suppress the Clang compiler warnings language level independent if the -Werror compile flag is present #1397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… newer boost libraries even when the project uses C++14 as the language standard and if the warnings are treated as errors (`Werror` flag exists). Failing to do this causes compilation failure when using newest boost 1.90.0. e.g.: ``` cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTS=ON -DBUILD_EXAMPLES=ON -DWITH_OPENSSL=ON -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_TOOLCHAIN_FILE=/Users/ihsan/Desktop/work/src/vcpkg/scripts/buildsystems/vcpkg.cmake -DVCPKG_MANIFEST_FEATURES='build-tests' "-DCMAKE_CXX_FLAGS=-Werror -m64 -Wall" -DCMAKE_INSTALL_PREFIX=/Users/ihsan/Desktop/work/src/hazelcast-cpp-client/cpp_install -G "Unix Makefiles" -S /Users/ihsan/Desktop/work/src/hazelcast-cpp-client -B /Users/ihsan/Desktop/work/src/hazelcast-cpp-client/cmake-build-arm-debug-vcpkg ``` Failures: ``` /Users/ihsan/Applications/CLion.app/Contents/bin/cmake/mac/aarch64/bin/cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTS=ON -DBUILD_EXAMPLES=ON -DWITH_OPENSSL=ON -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_TOOLCHAIN_FILE=/Users/ihsan/Desktop/work/src/vcpkg/scripts/buildsystems/vcpkg.cmake -DVCPKG_MANIFEST_FEATURES='build-tests' "-DCMAKE_CXX_FLAGS=-Werror -m64 -Wall" -DCMAKE_INSTALL_PREFIX=/Users/ihsan/Desktop/work/src/hazelcast-cpp-client/cpp_install -G "Unix Makefiles" -S /Users/ihsan/Desktop/work/src/hazelcast-cpp-client -B /Users/ihsan/Desktop/work/src/hazelcast-cpp-client/cmake-build-arm-debug-vcpkg ```
JackPGreen
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to suppress the Clang compiler warnings for known warnings in newer boost libraries even when the project uses C++14 as the language standard and if the warnings are treated as errors (
Werrorflag exists). Failing to do this causes compilation failure when using newest boost 1.90.0.e.g.:
Failures: