Rename SOURCE_REF release.yml parameter to VERSION#324
Open
JackPGreen wants to merge 1 commit intomasterfrom
Open
Rename SOURCE_REF release.yml parameter to VERSION#324JackPGreen wants to merge 1 commit intomasterfrom
SOURCE_REF release.yml parameter to VERSION#324JackPGreen wants to merge 1 commit intomasterfrom
Conversation
|
nishaatr
approved these changes
Feb 6, 2026
| SOURCE_REF: | ||
| description: 'The hazelcast-packaging branch to build from' | ||
| VERSION: | ||
| description: 'The version to build' |
Contributor
There was a problem hiding this comment.
Suggested change
| description: 'The version to build' | |
| description: 'The release version to build' |
Contributor
There was a problem hiding this comment.
nit
makes it more contextual
if you agree then update other PRs as forgot to mention there
Collaborator
Author
There was a problem hiding this comment.
Maybe "hazelcast version" would be clearer? Or maybe smurfy.
Want to avoid "release" as it might be a z branch SNAPSHOT etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See hazelcast/hazelcast-docker#1225
Post-merge actions: