Migrate hazelcast-wm to new Maven Central [DI-630]#210
Conversation
Test Results 15 files 15 suites 24m 57s ⏱️ Results for commit e7fe0d3. ♻️ This comment has been updated with latest results. |
`Findbugs` issues found during #210 - fix [errors](https://github.com/hazelcast/hazelcast-wm/actions/runs/18138331537/job/51622684517#step:8:395) using `volatile` - disabled Jenkins [WM-pr-builder](https://jenkins.hazelcast.com/job/WM-pr-builder/) as we have GH one. I checked and mirrored config. Tomasz thinks Josef might have started the migration but didn't have a chance to complete
There was a problem hiding this comment.
We should upgrade this separately and it should be managed automatically. I will take a look.
There was a problem hiding this comment.
thanks
revert or keep?
worth checking hazelcast-jdbc also
There was a problem hiding this comment.
sorry missed the approval so will keep
There was a problem hiding this comment.
thanks revert or keep? worth checking
hazelcast-jdbcalso
I've already done hazelcast-jdbc. Not sure how this was missed when I first introduced it.
I'd say revert to make this PR smaller but I don't really mind.
There was a problem hiding this comment.
great.
prefer to keep.
There was a problem hiding this comment.
There was a problem hiding this comment.
You could just've done it from the GitHub web UI...
There was a problem hiding this comment.
didn't come to mind.
preferred manual just in case!
There was a problem hiding this comment.
but GH UI still showing Update branch 😞
looks like known behavior
says change base branch temporarily via PR edit.
I will skip but good to know!
There was a problem hiding this comment.
ignore. just updated. master was truly updated #217
3 participants
Changes
Findbugsissues and resolved separately Fix Findbugs errors [DI-630] #212SNAPSHOTvia<distributionManagement>as using separate profiles<developer>MAVEN_ARGSin GH workflows.mvn/wrapper/maven-wrapper.properties(copied from Mono); otherwise,MAVEN_ARGSdoesn't take effect-Dgpg.passphrasewhen calling Maven in worflows as we haveMAVEN_GPG_PASSPHRASEactions/setup-jdkTesting
Snapshot
Version:
5.2-SNAPSHOTRelease
Version:
1.0.0Made changes on temp branch diff
Post tasks
Fixes DI-630