Open
Conversation
do not rely on default set on system
fsteeg
requested changes
Feb 11, 2026
Member
fsteeg
left a comment
fsteeg
left a comment
There was a problem hiding this comment.
In restart.sh, the JAVA_HOME should not be needed.
In monit_restart.sh, I'm surprised it works like this (just setting JAVA_HOME, not passing it to the activator). For consistency, I think we should do it like in transformAndIndexRppd.sh, with sbt --java-home $JAVA_HOME instead of activator.
fsteeg
approved these changes
Feb 11, 2026
|
This PR can be replaced by #14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not rely on system's default java version