fix(place_and_route): correct clock period extraction and fmax units #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAMS
changed the title
- Fix clock period extraction to match any clock name (not just 'clk') - Fix fmax unit conversion from MHz to GHz Fixes parsing of report_clock_properties and report_clock_min_period output for accurate PPA reporting.
MrAMS
force-pushed
the
fix-clock_name-and-fmax
branch
from
0a694e4 to
16ef289
Compare
Contributor
Author
|
related pr#418 |
Collaborator
|
/gcbrun |
Contributor
Author
|
CI passed, please review at your convenience ❤️ |
mikesinouye
approved these changes
Dec 9, 2025
Collaborator
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two critical bugs in
place_and_route/private/benchmark.bzlthat caused incorrect PPA (Power-Performance-Area) metric reporting from OpenROAD logs.Changes
Fix
clock_period_psextraction:/clk /was too restrictive and only matched clocks explicitly named "clk". This resulted inclock_period_psbeing 0 for clocks named "core_clock", "sys_clk", etc.awkcommand to robustly match any clock name in the OpenROAD timing table.Fix
fmax_ghzunit mismatch:fmaxin MHz, but the proto fieldfmax_ghzexpects GHz. This resulted in values being off by a factor of 1000 (e.g., 218 MHz reported as 218 GHz).Verification
Verified locally.
clock_period_psnow captures the correct period (e.g., 1250 ps) instead of 0, andfmax_ghznow reports realistic values (e.g., 0.218 GHz instead of 218.56 GHz).