Skip to content

Conversation

mavaylon1
Copy link
Contributor

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

This is to add validation and HERD generation for a subset of fields in the schema. This cannot be toggled off.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@mavaylon1
Copy link
Contributor Author

Note: The path used for the termset in the schema will be relative. The code is a outline that should mostly work with adjustments to path needed.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.85%. Comparing base (dfb1df7) to head (9547f07).
Report is 88 commits behind head on dev.

Files with missing lines Patch % Lines
src/hdmf/container.py 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1151      +/-   ##
==========================================
+ Coverage   88.83%   88.85%   +0.01%     
==========================================
  Files          45       45              
  Lines        9784     9791       +7     
  Branches     2779     2780       +1     
==========================================
+ Hits         8692     8700       +8     
+ Misses        776      775       -1     
  Partials      316      316              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mavaylon1 mavaylon1 self-assigned this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant