Check DynamicTableRegion data is in bounds #1168
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1168 +/- ##
===========================================
- Coverage 91.62% 37.91% -53.72%
===========================================
Files 42 42
Lines 9684 9707 +23
Branches 1963 1971 +8
===========================================
- Hits 8873 3680 -5193
- Misses 523 5696 +5173
- Partials 288 331 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| def setUp(self): | ||
| self.test_dir = tempfile.mkdtemp() | ||
| if os.path.exists(self.test_dir): # start clean |
There was a problem hiding this comment.
This code raised hidden errors during test setup. tempfile.mkdtemp() creates a clean temp directory so the below code is not needed
|
|
||
| def tearDown(self): | ||
| if os.path.exists(self.ns_filename): | ||
| if hasattr(self, 'ns_filename') and os.path.exists(self.ns_filename): |
There was a problem hiding this comment.
This code raised hidden errors during test setup when this test was skipped because ROS3 is not installed or there is no internet, because the instance vars are not defined before skipping and tearing down.
|
#1293 should be merged before this |
2 participants
Motivation
Fix #210
Checklist
CHANGELOG.mdwith your changes?