Skip to content

Conversation

bendichter
Copy link
Contributor

@bendichter bendichter commented May 1, 2025

in HDF5IO and update array display logic in generate_array_html_repr to handle LINDI datasets

Motivation

fix #1266

How to test the behavior?

import pynwb
import lindi

# Load https://api.dandiarchive.org/api/assets/2b9e441b-56bc-4be2-893e-0e02d22d239d/download/
f = lindi.LindiH5pyFile.from_lindi_file("https://lindi.neurosift.org/dandi/dandisets/000582/assets/2b9e441b-56bc-4be2-893e-0e02d22d239d/nwb.lindi.json")
nwb = pynwb.NWBHDF5IO(file=f, mode='r').read()

nwb

I am not sure how to test this behavior, as it depends on LINDI, which we would not want as a dependency

Copy link

codecov bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 37.82%. Comparing base (c604abb) to head (7c9fe93).

Files with missing lines Patch % Lines
src/hdmf/backends/hdf5/h5tools.py 0.00% 17 Missing ⚠️
src/hdmf/utils.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c604abb) and HEAD (7c9fe93). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (c604abb) HEAD (7c9fe93)
5 1
Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #1267       +/-   ##
===========================================
- Coverage   91.66%   37.82%   -53.84%     
===========================================
  Files          42       42               
  Lines        9550     9559        +9     
  Branches     1920     1922        +2     
===========================================
- Hits         8754     3616     -5138     
- Misses        518     5622     +5104     
- Partials      278      321       +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bendichter bendichter requested a review from rly May 1, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: HTML repr broken for LINDI

1 participant