Add error type wrapping all possible errors#122
Draft
DevinR528 wants to merge 2 commits intoheadcrab-rs:masterfrom
DevinR528:error-type
Draft
Add error type wrapping all possible errors#122DevinR528 wants to merge 2 commits intoheadcrab-rs:masterfrom DevinR528:error-type
DevinR528 wants to merge 2 commits intoheadcrab-rs:masterfrom
DevinR528:error-type
Conversation
bjorn3
reviewed
Oct 11, 2020
| use thiserror::Error; | ||
|
|
||
| #[derive(Error, Debug)] | ||
| pub enum CrabError { |
Contributor
There was a problem hiding this comment.
I think there should be a separate error type for target and one for symbol.
Author
There was a problem hiding this comment.
Does there still need to be a top-level wrapper for pub type CrabResult<T> = Result<T, ErrorType>;? Something like
pub enum CrabError {
Target(crate::target::TargetError),
Symbol(crate::symbol::SymbolError),
}
Author
There was a problem hiding this comment.
Or should each mod (target and symbol) have their own Result type?
Contributor
There was a problem hiding this comment.
Does there still need to be a top-level wrapper for pub type CrabResult = Result<T, ErrorType>;? Something like
That could be useful.
Or should each mod (target and symbol) have their own Result type?
Yes please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just wondering if I'm moving in the right direction? Any naming suggestions/ideas would be helpful as I am still getting my head around everything.