Skip to content

add target platform for dockerfile, mutli arch image builds #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add target platform for dockerfile, mutli arch image builds #135

wants to merge 1 commit into from
+10 −0

Conversation

ashu8912
Copy link
Member

@ashu8912 ashu8912 commented Dec 17, 2024 •
edited
Loading

docker buildx build \ --platform linux/amd64,linux/arm64 \ --build-arg PLUGIN=your-plugin-name \ -t your-image-name:tag \ --push \ .

illume
illume reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashu8912 is there an issue or slack comment for this? Can you please add more context to the PR description?

If we're adding an extra argument I'd expect we'd want to use it from somewhere and document it.

Dockerfile
@@ -41,6 +50,7 @@ COPY --from=builder /headlamp-plugins/build/ /plugins/

LABEL org.opencontainers.image.source=https://github.com/headlamp-k8s/plugins
LABEL org.opencontainers.image.licenses=MIT
LABEL org.opencontainers.image.platform=$TARGETPLATFORM
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if TARGETPLATFORM is empty? Is this still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illume illume illume left review comments

@joaquimrocha joaquimrocha Awaiting requested review from joaquimrocha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashu8912 @illume