cluster-api: sidebar fixes - order resources and show icons#550
Merged
illume merged 1 commit intoheadlamp-k8s:mainfrom Mar 15, 2026
Merged
cluster-api: sidebar fixes - order resources and show icons#550illume merged 1 commit intoheadlamp-k8s:mainfrom
illume merged 1 commit intoheadlamp-k8s:mainfrom
Conversation
Contributor
Author
|
@illume , PTAL |
Contributor
|
we usually don't put icons in the second level items since it makes it look quite busy. Maybe we can rework this a bit in the future, remove some margins, make it a bit wider, but right now I think we shouldn't have icons there |
- Reorder Cluster API sidebar: Clusters first, then Cluster Classes, control plane, worker scaling (MD, Pools, Sets, Machines), bootstrap config, operations Signed-off-by: Chayan Das <01chayandas@gmail.com>
ChayanDass
force-pushed
the
sidebar-fixes
branch
from
a3d8cbb to
de53a10
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Cluster API Headlamp plugin’s sidebar organization by reordering the resource registration list so items appear in a more intentional sequence in the UI.
Changes:
- Reorders
clusterApiResourcesto show Clusters first, then Cluster Classes, followed by control plane and worker-related resources. - Moves bootstrap/operational resources (e.g., Kubeadm Configs/Templates, MHCs, Drain Rules) later in the list to match the intended grouping.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
Author
|
@illume, PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Reorder Cluster API sidebar: Clusters first, then Cluster Classes, control plane, worker scaling (MD, Pools, Sets, Machines), bootstrap config, operations
Pass icon to registerSidebarEntry for each child so icons appear in sidebar
Note: This fixes the visibility of icons; the icon set itself may still need further updates.