fix(prometheus): handle plain text response in Prometheus connection test#559
Merged
illume merged 1 commit intoheadlamp-k8s:mainfrom Mar 20, 2026
Merged
fix(prometheus): handle plain text response in Prometheus connection test#559illume merged 1 commit intoheadlamp-k8s:mainfrom
illume merged 1 commit intoheadlamp-k8s:mainfrom
Conversation
Signed-off-by: jackey.zhang <jackey.zhang@woqutech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Prometheus plugin settings page, after manually configuring the Prometheus Service Address and clicking Test Connection, the frontend calls the Prometheus /-/healthy endpoint. That endpoint returns plain text, such as
'Prometheus Server is Healthy'.but the current implementation handles the response using the default JSON parsing path. As a result, the frontend throwsUnexpected token 'P' during parsing and incorrectly reports the connection as failed.This fix updates the connection test logic to handle the response as a raw HTTP response instead of forcing JSON parsing, and determines success based on the HTTP status code. This makes the test compatible with Prometheus health check endpoints that return plain text.