Merged
Conversation
cnotbohm
commented
Mar 4, 2026
Comment on lines
+1
to
+3
| #!/usr/bin/env python3 | ||
| import os | ||
| import sys |
Contributor
Author
There was a problem hiding this comment.
this file does any database test setup that was done in setup.py previously
cnotbohm
commented
Mar 4, 2026
Comment on lines
+22
to
+62
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.8", "3.9", "3.10", "3.11"] | ||
| django-version: ["3.2", "4.0", "4.1", "4.2"] | ||
| db-engine: ["sqlite", "mysql", "postgres"] | ||
| exclude: | ||
| - python-version: "3.11" | ||
| django-version: "3.2" | ||
| - python-version: "3.11" | ||
| django-version: "4.0" | ||
| services: | ||
| postgres: | ||
| image: postgres:12 | ||
| ports: | ||
| - 5432:5432 | ||
| options: >- | ||
| --health-cmd=pg_isready | ||
| --health-interval=10s | ||
| --health-timeout=5s | ||
| --health-retries=5 | ||
| env: | ||
| POSTGRES_DB: testdb | ||
| POSTGRES_USER: travis | ||
| POSTGRES_PASSWORD: travis | ||
| mysql: | ||
| image: mysql:8 | ||
| ports: | ||
| - 3306:3306 | ||
| options: >- | ||
| --health-cmd="mysqladmin ping" | ||
| --health-interval=10s | ||
| --health-timeout=5s | ||
| --health-retries=5 | ||
| env: | ||
| MYSQL_USER: travis | ||
| MYSQL_PASSWORD: travis | ||
| MYSQL_ALLOW_EMPTY_PASSWORD: true | ||
| MYSQL_DATABASE: test_testdb | ||
|
|
||
| steps: |
Contributor
Author
There was a problem hiding this comment.
this should make sure tests are run as they were before
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ff31a9667
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
limelator
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the library to poetry for building and publishing
it updates the documentation to be MD files
adds make commands
a future PR will update the library to include python 3.14 support and django 5.2 support