Skip to content

Use :unprocessable_content in generated Devise config for Rack 3.1+ #5797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosantoniodasilva merged 8 commits into from
Dec 31, 2025
+19 −8
Merged

Use :unprocessable_content in generated Devise config for Rack 3.1+ #5797

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ed625a8
Use Devise.responder.error_status instead of fixed :unprocessable_ent…
taketo1113 Sep 12, 2025
e7f5596
Use `:unprocessable_content` in generated Devise config for Rack 3.1+
taketo1113 Sep 12, 2025
9ac7f53
Merge branch 'main' into update-rack-unprocessable_content
carlosantoniodasilva Dec 31, 2025
9fa4d63
Revert changes to controllers
carlosantoniodasilva Dec 31, 2025
f8b8092
Add test for conditional error status
carlosantoniodasilva Dec 31, 2025
3d3e75b
Translate error status to code using Rails if available to avoid warning
carlosantoniodasilva Dec 31, 2025
9932bc5
Add changelog entry for rack error status
carlosantoniodasilva Dec 31, 2025
8c0c9a8
Use Rack::RELEASE since VERSION did not exist on older Rack
carlosantoniodasilva Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,8 @@ Devise.setup do |config|
# apps is `200 OK` and `302 Found` respectively, but new apps are generated with
# these new defaults that match Hotwire/Turbo behavior.
# Note: These might become the new default in future versions of Devise.
config.responder.error_status = :unprocessable_entity
config.responder.error_status = :unprocessable_content # for Rack 3.1 or higher
# config.responder.error_status = :unprocessable_entity # for Rack 3.0 or lower
Copy link
Member

@carlosantoniodasilva carlosantoniodasilva Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

config.responder.redirect_status = :see_other
end
```
Expand Down
4 changes: 2 additions & 2 deletions app/controllers/devise/confirmations_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ def show
set_flash_message!(:notice, :confirmed)
respond_with_navigational(resource){ redirect_to after_confirmation_path_for(resource_name, resource) }
else
# TODO: use `error_status` when the default changes to `:unprocessable_entity`.
respond_with_navigational(resource.errors, status: :unprocessable_entity){ render :new }
# Use `error_status` when the default changes to `:unprocessable_content` (or `:unprocessable_entity`).
respond_with_navigational(resource.errors, status: (Devise.responder.error_status != :ok) ? Devise.responder.error_status : Rack::Utils::SYMBOL_TO_STATUS_CODE.key(422) ){ render :new }
Copy link
Member

@carlosantoniodasilva carlosantoniodasilva Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert these controller changes and continue using :unprocessable_entity from here. I'll revisit with responders later, but for now we can rely on the fact that Rails will transparently handle it for us depending on the Rack version.

(I'm still considering making these code changes for v5, not sure it's something I want to bite just yet, as things have been working just fine for now, and there's already plenty of changes on v5 for people to upgrade... maybe in the next version)

end
end

Expand Down
4 changes: 2 additions & 2 deletions app/controllers/devise/unlocks_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ def show
set_flash_message! :notice, :unlocked
respond_with_navigational(resource){ redirect_to after_unlock_path_for(resource) }
else
# TODO: use `error_status` when the default changes to `:unprocessable_entity`.
respond_with_navigational(resource.errors, status: :unprocessable_entity){ render :new }
# Use `error_status` when the default changes to `:unprocessable_content` (or `:unprocessable_entity`).
respond_with_navigational(resource.errors, status: (Devise.responder.error_status != :ok) ? Devise.responder.error_status : Rack::Utils::SYMBOL_TO_STATUS_CODE.key(422) ){ render :new }
end
end

Expand Down
2 changes: 1 addition & 1 deletion lib/generators/templates/devise.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@
# apps is `200 OK` and `302 Found` respectively, but new apps are generated with
# these new defaults that match Hotwire/Turbo behavior.
# Note: These might become the new default in future versions of Devise.
config.responder.error_status = :unprocessable_entity
config.responder.error_status = <%= Rack::Utils::SYMBOL_TO_STATUS_CODE.key(422).inspect %>
config.responder.redirect_status = :see_other

# ==> Configuration for :registerable
Expand Down