Skip to content

add installation options for gui, utils, and all and update ci test accordingly.#32

Merged
heberlr merged 7 commits intoheberlr:dev_heberfrom
elmbeech:patch_installl
Mar 20, 2026
Merged

add installation options for gui, utils, and all and update ci test accordingly.#32
heberlr merged 7 commits intoheberlr:dev_heberfrom
elmbeech:patch_installl

Conversation

@elmbeech
Copy link
Contributor

No description provided.

@elmbeech elmbeech changed the title add installation options for gui and all. add installation options for gui, utils, and all. Mar 19, 2026
@elmbeech elmbeech changed the title add installation options for gui, utils, and all. add installation options for gui, utils, and all and update ci test accordingly. Mar 19, 2026
pyproject.toml Outdated
"gpytorch"

gui = [
"pyqt5",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I think it would be better to integrate these GUI dependencies into the general dependencies and remove this GUI option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to modify the pr as you want to.

Added 'pyqt5' and 'seaborn' to the main dependencies and removed them from the 'gui' optional dependencies.
@elmbeech
Copy link
Contributor Author

i think it is good practice to order the dependencies alphabetically.
this makes it in future easy to ckeck and update.
but that is just my opinion ymmv and in the end, this is your code.

@heberlr heberlr merged commit c09a6ea into heberlr:dev_heber Mar 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants