Move potions to belt after corpse recovery#731
Open
Sunblood wants to merge 5 commits intohectorgimenez:mainfrom
Open
Move potions to belt after corpse recovery#731Sunblood wants to merge 5 commits intohectorgimenez:mainfrom
Sunblood wants to merge 5 commits intohectorgimenez:mainfrom
Conversation
This pr enable Shift Key usage. ctx.HID.ClickWithModifier(game.LeftButton, screenPos.X, screenPos.Y, game.ShiftKey) Used for Equipping gear or moving back potions to belt in correct order if we died. Assembly code that returns -32768 (0x8000) for shift key only sets rax to 0x8000 if the key matches,otherwise it returns 0 (due to the initial xor). starts by zeroing rax, which provides a default "key not pressed" state. use single-byte comparisons Original code would always return 0x8000 after doing the comparison, which explains why the modifier behavior wasn't working correctly . It was reporting the key as pressed regardless of which key was being queried.
Collaborator
|
@Sunblood this should be a part of the belt management script. Also clicking all potions can make unwanted potions go in the belt. Check the logic for belt management and implement something similar, only shift+click a pot when needed/has a missing one in the belt |
Contributor
|
Yeah belt doesnt remember emplacement for potions after you died. It isnt completely random but have to help it a little bit. However if 1 potion is on each row( no holes) it would work so need little logic here. Technically when you die it keeps one potion of each in belt( in wanted order) unless you had none left( rejuv will be more tricky for that) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shift + left clicks on all potions in inventory so they move back into belt slots instead of getting sold.
Requires Shift+click fix from #684 to function correctly