Emit required array in tool schema based on @Nullable#148
Open
christophercolumbusdog wants to merge 2 commits intohelidon-io:mainfrom
Open
Emit required array in tool schema based on @Nullable#148christophercolumbusdog wants to merge 2 commits intohelidon-io:mainfrom
christophercolumbusdog wants to merge 2 commits intohelidon-io:mainfrom
Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
1 task
The tool annotation processor now checks parameter annotations and type-use annotations for @nullable. Parameters without it are collected into a JSON Schema "required" array, letting MCP clients distinguish mandatory from optional tool inputs. Fixes helidon-io#146
b56b76f to
bb090f0
Compare
|
Thank you for signing the OCA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Nullableon parameters (both element and TYPE_USE annotations) and emits a"required"array in the generated JSON schema for non-nullable parametersFixes #146
Changes
McpCodegenUtil— addisNullablehelper that checks bothannotations()andelementTypeAnnotations()for any annotation namedNullableMcpJsonSchemaCodegen— add overload ofaddSchemaMethodBodythat accepts required field names and emits"required": [...]between the properties close and root object closeMcpToolCodegen— collect non-nullable parameter names during schema generation and pass them throughExample
Given:
Before:
{"type": "object", "properties": {"changeId": {...}, "message": {...}}}After:
{"type": "object", "properties": {"changeId": {...}, "message": {...}}, "required": ["changeId"]}