This repository was archived by the owner on Mar 5, 2024. It is now read-only.
Open
Conversation
andymck
force-pushed
the
andymck/reject-poc-requests
branch
from
0e3b006 to
81d8c90
Compare
andymck
requested review from
Vagabond and
evanmcc
and removed request for
Vagabond
Comment on lines
+1040
to
+1042
| case Value of | ||
| true -> ok; | ||
| false -> ok; |
Contributor
There was a problem hiding this comment.
Suggested change
| case Value of | |
| true -> ok; | |
| false -> ok; | |
| case Value of | |
| Bool when is_boolean(Bool) -> ok; |
Contributor
There was a problem hiding this comment.
personally, I like
validate_var(?poc_reject_requests, Value) when is_boolean(Value) -> ok;
validate_var(?poc_reject_requests, Value) -> throw({error, {poc_reject_requests, Value}}).
but I know that multi-head style is controversial
Vagabond
approved these changes
May 11, 2022
Contributor
|
We're going to hold this for 1.11.x and do the filtering in the sidecar until then see helium/miner#1600 |
vihu
approved these changes
May 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once val challengers are enabled, we dont want to be accepting poc request txns from hotspots, they just create noise.