This repository was archived by the owner on Mar 5, 2024. It is now read-only.
Open
Conversation
Contributor
|
We added the dep to the app file so this maybe doesn't need to be reverted? |
Contributor
Author
Now, I'm really confused. New tests wouldn't have passed prior to creating the original PR if there was such a missing dependency. Everything with blockchain-core remain a bit alien to me since I don't follow the relevant Discord channels or its PRs closely enough. Therefore, I'll leave that decision to others. My rationale was that if this feature requires a chain var which has been put on hold, there's no reason for this feature code to exist (for now). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix helium/miner#1779 by reverting #1412
per conversation with @mikev
test/blockchain_state_channel_SUITE.erlwget https://github.com/helium/blockchain-core/pull/1412.diff patch -p1 --reverse < 1412.diff