Conversation
kurotych
force-pushed
the
add-entity-key-to-mapping-act-req
branch
from
5512ef6 to
b8dade7
Compare
madninja
reviewed
Jun 4, 2025
kurotych
force-pushed
the
add-entity-key-to-mapping-act-req
branch
from
b8dade7 to
840711c
Compare
madninja
reviewed
Jun 4, 2025
src/service/poc_mobile.proto
Outdated
| bytes signature = 8; | ||
| // Base58-encoded string representing the entity key | ||
| // String representing the entity key | ||
| // Gets "points-based" mapping rewards to a single configured asset |
Member
There was a problem hiding this comment.
"Overrides the subscriber_id as the entity_key to send mapping rewards to"
madninja
approved these changes
Jun 4, 2025
bbalser
reviewed
Jun 5, 2025
src/service/poc_mobile.proto
Outdated
| bytes signature = 8; | ||
| // String representing the entity key | ||
| // Overrides the subscriber_id as the entity_key to send mapping rewards to | ||
| string entity_key = 9; |
Contributor
There was a problem hiding this comment.
can we make the name more descriptive? might be to verbose but something like reward_override_entity_key?? I know the comment explains the purpose, but the field just being named entity_key won't help when reading the code that utilizes it
bbalser
approved these changes
Jun 5, 2025
kurotych
changed the title
bbalser
approved these changes
Jun 11, 2025
kurotych
changed the title
reward_override_entity_key field to the subscriber_reward and subscriber_mapping_activity_req_v1
Contributor
|
Having this new field as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.