Move MsgVerify from oracles to proto

[connormck333]

MsgVerify trait originally belonged to oracles/file_store but was moved to oracles/file_store_oracles to remove the helium_proto dependency on file_store. This meant that cdr_service depended on file_store_oracles as it also uses MsgVerify.

We don't want to move MsgVerify to helium-proto as that would add a dependency on helium-crypto. Instead, I created a new trait MsgHasSignature which will be added to all protos with a signature field. MsgVerify has been moved to helium-wallet-rs where it will add a verify() method to all protos with a MsgHasSignature trait.

[madninja]

I am not a big fan of this change. We use helium/
-lib to tie together libraries at a higher level. Let’s have it there

[michaeldjeffrey]

I am not a big fan of this change. We use helium/ -lib to tie together libraries at a higher level. Let’s have it there

I don't think it belongs in helium-lib. This verification is specific to prost messages.
Putting it in helium-lib would mean adding prost over there. And adding some features to exclude solana deps.

[madninja]

I am not a big fan of this change. We use helium/ -lib to tie together libraries at a higher level. Let’s have it there

I don't think it belongs in helium-lib. This verification is specific to prost messages. Putting it in helium-lib would mean adding prost over there. And adding some features to exclude solana deps.

After a bit of discussion, I think we came to the proposal to add a helium-proto-ext workspace member to the helium-wallet-rs repo.. that way helium-lib and the new proto-ext crate share the same crypto and proto versions, while allowing other crates to pick up the helper functions without getting into solana dependencies

[connormck333]

I am not a big fan of this change. We use helium/ -lib to tie together libraries at a higher level. Let’s have it there

I don't think it belongs in helium-lib. This verification is specific to prost messages. Putting it in helium-lib would mean adding prost over there. And adding some features to exclude solana deps.

After a bit of discussion, I think we came to the proposal to add a helium-proto-ext workspace member to the helium-wallet-rs repo.. that way helium-lib and the new proto-ext crate share the same crypto and proto versions, while allowing other crates to pick up the helper functions without getting into solana dependencies

We had another chat about this change. If we were to keep MsgVerify in helium-proto, then we can use a proc macro to detect the signature field and automatically have the verify method. It also saves us from having to update helium-lib everytime we add a new proto and want the verify method. Let us know what you think.