Skip to content

terminal: use fallback values for the terminal size #14442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

terminal: use fallback values for the terminal size #14442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions helix-tui/src/terminal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ where
/// Wrapper around Terminal initialization. Each buffer is initialized with a blank string and
/// default colors for the foreground and the background
pub fn new(backend: B) -> io::Result<Terminal<B>> {
let size = backend.size()?;
let size = nonempty_terminal_size(backend.size());
Terminal::with_options(
backend,
TerminalOptions {
Expand Down Expand Up @@ -236,6 +236,13 @@ where

/// Queries the real size of the backend.
pub fn size(&self) -> io::Result<Rect> {
self.backend.size()
Ok(nonempty_terminal_size(self.backend.size()))
}
}

fn nonempty_terminal_size(size: io::Result<Rect>) -> Rect {
size.unwrap_or_else(|e| {
log::warn!("{}. Using default terminal size", e);
Rect::new(0, 0, 80, 24)
})
}
Loading