Update zenburn theme

[jakobj]

As the title suggests.

Building on @theli-ua 's work, I've attempted to faithfully port the complete color palette and map them to tree-sitter scopes. I like the way it turned out, but have only checked python, rust, and markdown highlighting, so this PR could benefit from additional set of eyes and maybe some testing, e.g., by @theli-ua :)

ps: also included the missing license file

[theli-ua]

idk about adding license and credits (as I never added port credits there, though this does look like a common practice?)

While testing theme one thing immediately threw me off is that you removed any differentiation between comments and doc comments in rust. They are currently marked as bold and with this PR this differentiation is completely removed. They are marked as bold with zenburn in vim

Next is the indent guide is now way too contrast, zenburn is stated to be "low-contrast color scheme" according to their website.

current:

pr:

vim:

Note that true also removes bold, it seems like in the original themes NULL as well as TRUE would be marked as bold and that was the intention (even though in the vim screenshot it does not recognize true/false):

also the paths in imports do seem to match color of the original theme better now however it looks a bit off without bolding.

To summarize

• doc comments bold
• true/false bold?
• ident guides way to high contrast (why change them?)
• imports need bold
• mod names bold

[jakobj]

Thanks for the timely feedback @theli-ua ! I've just updated the PR with all your suggestions. Here's what it looks like now

Re: license I've just followed the guidlines here https://github.com/helix-editor/helix/tree/master/runtime/themes#user-submitted-themes

Might also be appropriate to include you explicitly as an author in the theme file, what do you think?

[theli-ua]

imports still seem off?

pr:

vim:

I do like that helix theme has less contrast on the current line number, I'm not sure we meed to match how use or mod statements look like

What do you think?

keywords (like true false) are not bold:

Original theme (and current theme in zenburn) marks keywords as bold:

hi Keyword guifg=#f0dfaf gui=bold ctermfg=223 cterm=bold

Status line is much darker in original theme

pr:

master:

vim:

[jakobj]

• Imports: the new version seems to be as close to vim as I can make it (using the Include colors for the tree-sitter namespace node). Any suggestions on how to better match the original theme are appreciated 🙏
• Linenr: Good catch! Since we're trying to create a faithful port, I've updated this to match the original theme. This also forced me to change the gutter background, hope this doesn't break anything else. Looks like this now

• True/False: I think these are not bold in the original theme, e.g. from gvim

as these are styled by the Boolean color, see https://github.com/jnurmine/Zenburn/blob/master/colors/zenburn.vim#L244 and https://vimhelp.org/syntax.txt.html#%3Asyn-files . But other keywords we also make bold (https://github.com/jakobj/helix/blob/enh/zenburn-rework/runtime/themes/zenburn.toml#L42)

• Statusline: Good catch, fixed! Apparently in vim the statusline colors are reversed, because why not ;)

[theli-ua]

Latest commit seem to have changed colors for git changed/edited/added lines
master:

pr:

I this intentional?

Also, it's been few years sine I've used vim/zenburn, is that warning/hing bright white color how it was in the original theme?

The errors on the status line are also inverted/wrong:

[jakobj]

• git: This was not intentional, fixed now. Needed to style highlighting in diff view and gutter separately. I copied your suggestion to use red (string) color to highlight diff.minus in the gutter.
• warning/hint: Not sure since I moved from emacs to helix and emacs zenburn is quite different from the original theme. I just used the Todo color from the original theme. We could use something darker if you prefer?
• statusline: Apparently the "reversed" modifier from the statusline also affect the color for the error bullet. Not sure this is intentional(?), but I've worked around it now by manually reversing fg/bg of the status line.

[theli-ua]

I've been using this for couple days now and it seems fine to me