fix(sonokai): add primary cursor colors #14461
Open
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many themes, including my personal favorite sonokai, specify the
ui.cursor.*
settings but don't yet haveui.cursor.primary.*
settings configured. This causes primary cursor colors not to change correctly when switching to visual mode (for example).I've fixed it for sonokai at least in this PR. A similar issue has been previously discussed here.
This strikes me as a band-aid, however. I think the issue should be solved more fundamentally, though I'm unsure which approach the Helix project would prefer: