Skip to content

Conversation

alfiejfs
Copy link

If you click on "Contributing" when looking at https://github.com/helix-editor/helix, the link to architecture.md does not work (as it is relative). It does work when you are in the docs folder viewing CONTRIBUTING.md but I imagine this is not the most common way to read the file -- so I propose making the link absolute.

@alfiejfs alfiejfs force-pushed the fix-architecture-link branch from 13b4968 to 052cc30 Compare September 16, 2025 23:45
@archseer
Copy link
Member

The link in the README works fine for me, we certainly shouldn't have to hardcode URLs

@alfiejfs
Copy link
Author

I can only describe the behaviour as I observe it. If you go to https://github.com/helix-editor/helix, scroll down and click Contributing and then click the architecture.md link, it takes you to https://github.com/helix-editor/helix/blob/master/architecture.md which does not exist.

I am not sure of another solution other than hardcoding.

@the-mikedavis
Copy link
Member

That set of steps works correctly for me. I see GitHub using

<a href="/helix-editor/helix/blob/master/docs/architecture.md">architecture.md</a>

for the link.

@alfiejfs
Copy link
Author

Hmm, interesting. I have:

<a href="/helix-editor/helix/blob/master/architecture.md">architecture.md</a>

It must be some sort of Github issue? Feel free to close if you think so.

@the-mikedavis
Copy link
Member

Hmm yeah I don't see why it would be different across browsers. I tried a few and didn't see any difference so I will close this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants