Merged
Conversation
simensrostad
had a problem deploying
to
production
GitHub Actions
Failure
simensrostad
had a problem deploying
to
production
GitHub Actions
Failure
There was a problem hiding this comment.
Pull Request Overview
This PR adds handling for a new FOTA (Firmware Over The Air) event NRF_CLOUD_FOTA_FMFU_VALIDATION_NEEDED that was introduced in an SDK update. The implementation disconnects from LTE and CoAP networks before applying the firmware update to prevent CI failures.
- Adds case handling for
NRF_CLOUD_FOTA_FMFU_VALIDATION_NEEDEDevent - Implements network disconnection before applying FMFU (Full Modem Firmware Update)
- Includes error handling for the update application process
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
simensrostad
force-pushed
the
fix-fmfmu
branch
2 times, most recently
from
b69fd34 to
6aad55c
Compare
simensrostad
had a problem deploying
to
production
GitHub Actions
Failure
simensrostad
force-pushed
the
fix-fmfmu
branch
from
6aad55c to
e673b10
Compare
This change addresses the NRF_CLOUD_FOTA_FMFU_VALIDATION_NEEDED event that was introduced in the updated nRF SDK version, which is currently causing CI nightly failures. Changes: - Add NETWORK_DISCONNECT event handling in network module - Implement proper state transitions for LTE disconnection - Update FOTA module with new states for FMFU validation scenario The system now correctly disconnects from LTE when the validation event is received, ensuring proper FOTA completion for FMFU. Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
simensrostad
force-pushed
the
fix-fmfmu
branch
from
e673b10 to
24fd4c8
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disconnect from lte and coap whenever the
NRF_CLOUD_FOTA_FMFU_VALIDATION_NEEDED event is received. This event was introduced when the sdk nrf version was updated. And CI nightly is currently failing due to it being unhandled.