Fix integration tests

Author: bilaljaved

extension/prometheus/prometheus.go

@@ -9,13 +9,15 @@ import (
 
 const namespace = "goengine"
 
+// Metrics is an object for exposing prometheus metrics
 type Metrics struct {
 	notificationCounter            *prometheus.CounterVec
 	notificationQueueDuration      *prometheus.HistogramVec
 	notificationProcessingDuration *prometheus.HistogramVec
 	notificationStartTimes         map[string]time.Time
 }
 
+// NewMetrics instantiate and return an object of Metrics
 func NewMetrics() *Metrics {
 	return &Metrics{
 		// notificationCounter is used to expose 'notification_count' metric
@@ -66,7 +68,7 @@ func (m *Metrics) RegisterMetrics(registry *prometheus.Registry) error {
 	return registry.Register(m.notificationProcessingDuration)
 }
 
-// ReceivedNotification
+// ReceivedNotification counts received notifications
 func (m *Metrics) ReceivedNotification(isNotification bool) {
 	labels := prometheus.Labels{"is_notification": strconv.FormatBool(isNotification)}
 	m.notificationCounter.With(labels).Inc()

metrics_nop.go

@@ -1,5 +1,6 @@
 package goengine
 
+// NopMetrics is default Metrics handler in case nil is passed
 var NopMetrics Metrics = &nopMetrics{}
 
 type nopMetrics struct{}

test/projector_aggregate_integration_test.go

@@ -93,6 +93,7 @@ func (s *aggregateProjectorTestSuite) TestRunAndListen() {
 		time.Millisecond,
 		time.Second,
 		s.GetLogger(),
+		s.Metrics,
 	)
 	s.Require().NoError(err)
 
@@ -109,6 +110,7 @@ func (s *aggregateProjectorTestSuite) TestRunAndListen() {
 			return driverSQL.ProjectionFail
 		},
 		s.GetLogger(),
+		s.Metrics,
 	)
 	s.Require().NoError(err, "failed to create projector")
 
@@ -206,6 +208,7 @@ func (s *aggregateProjectorTestSuite) TestRunAndListen() {
 				return driverSQL.ProjectionFail
 			},
 			s.GetLogger(),
+			s.Metrics,
 		)
 		s.Require().NoError(err, "failed to create projector")
 

test/projector_stream_integration_test.go

@@ -102,6 +102,7 @@ func (s *streamProjectorTestSuite) TestRunAndListen() {
 		time.Millisecond,
 		time.Second,
 		s.GetLogger(),
+		s.Metrics,
 	)
 	s.Require().NoError(err)