Fix tests

Author: bilaljaved

driver/sql/postgres/projector_aggregate_bench_test.go

@@ -181,6 +181,7 @@ func setup(
 			return driverSQL.ProjectionFail
 		},
 		goengine.NopLogger,
+		goengine.NopMetrics,
 	)
 	require.NoError(b, err, "failed to create aggregate projector")
 

extension/prometheus/prometheus.go

@@ -2,7 +2,6 @@ package prometheus
 
 import (
 	"fmt"
-	"github.com/hellofresh/goengine/driver/sql"
 	"github.com/prometheus/client_golang/prometheus"
 	"strconv"
 	"time"
@@ -74,19 +73,19 @@ func (m *Metrics) ReceivedNotification(isNotification bool) {
 }
 
 // QueueNotification returns http handler for prometheus
-func (m *Metrics) QueueNotification(notification *sql.ProjectionNotification) {
+func (m *Metrics) QueueNotification(notification interface{}) {
 	key := "q" + fmt.Sprintf("%p", notification)
 	m.notificationStartTimes[key] = time.Now()
 }
 
 // StartNotificationProcessing is used to record start time of notification processing
-func (m *Metrics) StartNotificationProcessing(notification *sql.ProjectionNotification) {
+func (m *Metrics) StartNotificationProcessing(notification interface{}) {
 	key := "p" + fmt.Sprintf("%p", notification)
 	m.notificationStartTimes[key] = time.Now()
 }
 
 // FinishNotificationProcessing is used to observe end time of notification queue and processing time
-func (m *Metrics) FinishNotificationProcessing(notification *sql.ProjectionNotification, success bool, retry bool) {
+func (m *Metrics) FinishNotificationProcessing(notification interface{}, success bool, retry bool) {
 	memAddress := fmt.Sprintf("%p", notification)
 	queueStartTime := m.notificationStartTimes["q"+memAddress]
 	processingStartTime := m.notificationStartTimes["p"+memAddress]

test/internal/suite.go

@@ -1,6 +1,7 @@
 package internal
 
 import (
+	"github.com/hellofresh/goengine/extension/prometheus"
 	"testing"
 
 	"github.com/hellofresh/goengine"
@@ -16,6 +17,8 @@ type Suite struct {
 
 	Logger     *logrus.Logger
 	LoggerHook *test.Hook
+
+	Metrics *prometheus.Metrics
 }
 
 // SetupTest set logrus output to use the current testing.T
@@ -25,6 +28,8 @@ func (s *Suite) SetupTest() {
 	s.Logger.SetOutput(NewLogWriter(s.T()))
 
 	s.LoggerHook = test.NewLocal(s.Logger)
+
+	s.Metrics = prometheus.NewMetrics()
 }
 
 // TearDownTest cleanup suite variables

test/projector_aggregate_integration_test.go

@@ -260,6 +260,7 @@ func (s *aggregateProjectorTestSuite) TestRun() {
 			return driverSQL.ProjectionFail
 		},
 		s.GetLogger(),
+		s.Metrics,
 	)
 	s.Require().NoError(err, "failed to create projector")