Open
Conversation
Closes #1041 Signed-off-by: yxxhero <11087727+yxxhero@users.noreply.github.com> Signed-off-by: yxxhero <aiopsclub@163.com>
Closes #1041 Signed-off-by: yxxhero <11087727+yxxhero@users.noreply.github.com> Signed-off-by: yxxhero <aiopsclub@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.Event.Erroris not populated forcleanupglobal hooks #1041 by propagating errors to cleanup global hookswithPreparedChartscallback signature fromfunc()tofunc() []errorTriggerGlobalCleanupEventto accept an error parameterThis fix ensures that
.Event.Erroris properly populated forcleanupglobal hooks when releases fail, matching the behavior already present forpostsyncrelease hooks.Changes
pkg/app/run.go: Modified
withPreparedChartsto capture errors from the callback and pass the first error toTriggerGlobalCleanupEventpkg/state/state.go: Updated
TriggerGlobalCleanupEventto accept anevtErr errorparameterpkg/app/app.go: Updated all callback functions to return
[]errorTest Plan
make checkpassesReferences
.Event.Erroris not populated forcleanupglobal hooks #1041