♻️ refactor: using github.com/fatih/color for colors#9
Open
mhkarimi1383 wants to merge 2 commits intohelmwave:mainfrom
Open
♻️ refactor: using github.com/fatih/color for colors#9mhkarimi1383 wants to merge 2 commits intohelmwave:mainfrom
mhkarimi1383 wants to merge 2 commits intohelmwave:mainfrom
Conversation
Signed-off-by: Muhammed Hussein Karimi <info@karimi.dev>
Signed-off-by: Muhammed Hussein Karimi <info@karimi.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
I have refactored the code to use https://github.com/fatih/color since it also has support for Windows (I'm Linux user, but in our team we have other users that are using Windows and we are using @halmwave itself and internal projects logging section is made by logrus sometimes), and making it easier to play with colors.
Also if needed I can move
color.Newfrom variable into the Format function, I don't know witch one will make it more clear to you.and I change the code to manage enabling or disabling color using
colorpackage itself