Upgrades Remarkable and highlight.js #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcculloh-kr
commented
Oct 30, 2023
| assert.equal( | ||
| actual, | ||
| '<h1>EEE</h1>\n<pre><code class="lang-javascript"><span class="hljs-keyword">var</span> message = <span class="hljs-string">\'This is an alert\'</span>;\n<span class="hljs-title function_">alert</span>(message);\n</code></pre>\n' | ||
| ); |
There was a problem hiding this comment.
The proper syntax for the code block is to specify a language after the triple back-ticks. If you remove javascript from test/fixtures/e.md this assert will pass without needing this modification, however you'll get a warning in your console notifying you that you forgot to pass in a language. Once I tested this and confirmed that it worked (without the javascript) I went ahead and added it and then updated the assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses security concerns with old versions of both of these libraries.
These vulnerabilities were found through an internal tool called "Snyk". You can see the vulnerability reports below. Basically the issue is that you need to upgrade your versions of remarkable and highlight.js.