Skip to content

chore: arm versioning #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

chore: arm versioning #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e742a4d
chore: arm versioning
FoseFx Apr 10, 2023
6193cd1
Merge branch 'main' into issue/125-rearm-versioning
felixevers Jun 27, 2023
ced5c35
Merge branch 'main' into issue/125-rearm-versioning
felixevers Jul 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/buf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: bufbuild/buf-setup-action@v1
# TODO (arm-versioning): Arm versioning by removing the comments of the following lines
# - uses: bufbuild/buf-breaking-action@v1
# with:
# against: 'https://github.com/${{ github.repository }}.git#branch=main'
- uses: bufbuild/buf-breaking-action@v1
with:
against: 'https://github.com/${{ github.repository }}.git#branch=main'
9 changes: 3 additions & 6 deletions .github/workflows/publish-bufs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,11 @@ jobs:
fetch-depth: 2
- uses: bufbuild/buf-setup-action@v1
- uses: bufbuild/buf-lint-action@v1
# TODO (arm-versioning): Arm versioning by remove the comment of ONLY the next line
# - name: Check for illegal breakage
- name: Check for illegal breakage
# Only deletions are allowed. Breaking updates must happen in a new version of the package(s) in question.
# This is just a sanity check!
# For example it allows you to delete files from the latest version of a package (depending on context that might even be ok).
# TODO (arm-versioning): Arm versioning by remove the comment of the next line
# run: buf breaking --against '.git#ref=HEAD^' --error-format json | jq .type | if grep -v -q \"FILE_NO_DELETE\"; then exit 1; fi
run: buf breaking --against '.git#ref=HEAD^' --error-format json | jq .type | if grep -v -q \"FILE_NO_DELETE\"; then exit 1; fi
- name: Has breakage?
id: breaking
# We previously checked if any illegal breakage occurred, now check if we have breakage _at all_
Expand All @@ -52,8 +50,7 @@ jobs:
run: |
BUMP="patch"
if [ "$BREAKING" = "true" ]; then
# TODO (arm-versioning): Arm versioning by replacing the following "minor" with "major"
BUMP="minor"
BUMP="major"
elif [ "$NEW_PKG" = "true" ]; then
BUMP="minor"
else
Expand Down