Implementation of the executeQuery method of StdCouchDbConnector,#192
Open
ceefour wants to merge 1 commit intohelun:masterfrom
Open
Implementation of the executeQuery method of StdCouchDbConnector,#192ceefour wants to merge 1 commit intohelun:masterfrom
executeQuery method of StdCouchDbConnector,#192ceefour wants to merge 1 commit intohelun:masterfrom
Conversation
from the discussion in helun#165, which prefers `GET` HTTP method even in case of multiple keys. It is more appropriate for hosted services like <a href="http://cloudant.com/">Cloudant</a> where `POST` requests are charged more than `GET`. However, if the HTTP request length exceeds `MAX_KEYS_LENGTH_FOR_GET` characters, it will use `POST` HTTP method. `ViewQuery` needed to be factored slightly to support its usage.
This was referenced Sep 18, 2014
Collaborator
|
hi @ceefour why do you need a new public method getKeysAsJsonArray() on ViewQuery when you already have getKeysValues() and getKeys(). was the dependency change on logging framework nescessary ? |
YannRobert
requested changes
Mar 15, 2017
Collaborator
YannRobert
left a comment
YannRobert
left a comment
There was a problem hiding this comment.
see comment #192 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from the discussion in #165,
which prefers
GETHTTP method even in case of multiple keys.It is more appropriate for hosted services like Cloudant
where
POSTrequests are charged more thanGET.However, if the HTTP request length exceeds
MAX_KEYS_LENGTH_FOR_GETcharacters,it will use
POSTHTTP method.ViewQueryneeded to be factored slightly to support its usage.