Support afterGracefulShutdown callback, clarify usage#57
Open
kibertoad wants to merge 3 commits intohemerajs:masterfrom
Open
Support afterGracefulShutdown callback, clarify usage#57kibertoad wants to merge 3 commits intohemerajs:masterfrom
kibertoad wants to merge 3 commits intohemerajs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behaviour is likely not what majority of users are going to expect - callback is only for preparing/starting graceful shutdown, but not for wrapping things up after requests were drained and no new ones are going to arrive. Clarified documentation and provided a new callback for those who need post-shutdown hook for graceful termination cases.
fixes #56