Merged
Conversation
…st coverage - Remove dead code: LogEvent.initLegacy() and Span.initLegacy() - Add comprehensive tests for all modules (trace, field, config, event, redaction, correlation) - Ensure all public functions are tested to address Zig's lazy compilation - Remove 66+ lines of unused legacy code and associated tests This ensures the Zig compiler type-checks all functions since Zig only compiles code that's actually used.
hendriknielaender
force-pushed
the
improved-test-suite
branch
from
e72f657 to
8ca52b9
Compare
…tLegacy functions - Add tests for field.zig: Field constructors, value types, constraints - Add tests for config.zig: Level methods, Config defaults and custom values - Add tests for event.zig: LogEvent creation and formatting - Add tests for redaction.zig: RedactionConfig operations and RedactionOptions - Add tests for correlation.zig: Span, TaskContext, CorrelationContext operations - Remove unused initLegacy functions from event.zig and correlation.zig This ensures all public functions are tested to address Zig's lazy compilation where untested code doesn't get type-checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #17