Isolate Minecraft from voicechat #853
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Isolates Minecraft from all but 9 classes. Mostly by replacing API class Impl methods with their api interface counterparts. Ideally, making it easier to update and so that I may publish an api impl that allows the server to be run separately from the Minecraft server.
Make whatever changes you wish. And I would be willing to implement any you request. The common and core modules do not need to remain separated, but they should before any changes are made; otherwise, Minecraft classes may leak through, and that would kind of destroy the purpose.